Enforce qualifier update for project(s) with comparator errors

[eclipse-releng-bot]

Enforce qualifier update for project(s) with comparator error in build I20260612-1800.

[HannesWell]

@vogella is this comparator error expected due to your CSS engine rework submitted yesterday?
https://download.eclipse.org/eclipse/downloads/drops4/I20260612-1800/#git-log

[vogella]

To be honest I have no idea what a comparator error actually means. But the error seems to be for the CSS spy class which was not touched yesterday.

Comparator differences from current build
/home/jenkins/agent/workspace/Builds/I-build-4.41/cje-production/siteDir/eclipse/downloads/drops4/I20260612-1800
compared to reference repo at
https://download.eclipse.org/eclipse/updates/4.41-I-builds/

1. eclipse.pde/ui/org.eclipse.pde.spy.css/.polyglot.META-INF
   no-classifier: different
   org/eclipse/pde/spy/css/CssSpyPart.class: different
   The main artifact has been replaced with the baseline version.
   The following attached artifacts have been replaced with the baseline version: [sources]

[akurtakov]

One has to:

• go to https://download.eclipse.org/eclipse/downloads/drops4/I20260612-1800/buildlogs/logs.html
• download https://download.eclipse.org/eclipse/downloads/drops4/I20260612-1800/buildlogs/comparatorlogs/artifactcomparisons.zip
• extract the content and go down to find the class in question
• run a diff between CssSpyPart.class-baseline and CssSpyPart.class-build to see the actual diff

@HannesWell Is it possible to make this diff shown directly in some page so more people can check it?

[github-actions]

Test Results

  126 files  ±0    126 suites  ±0   37m 22s ⏱️ - 1m 27s
3 516 tests ±0  3 462 ✅ ±0   54 💤 ±0  0 ❌ ±0 
9 351 runs  ±0  9 221 ✅ ±0  130 💤 ±0  0 ❌ ±0 

Results for commit 5e65faa. ± Comparison against base commit d0a78c5.

[vogella]

The CSS commit did change the Selector class and I prepared the CSS spy for this by using var for the variable type. So maybe this results for the above check to a need to update?

[HeikoKlare]

As can be seen in the diff of the class files mentinoed by Alex, it's about the replacement of the SAC selector with an internal selector, e.g.:

So the diff is probably an expected result from:

• Replace SAC selector layer with an internal Selector AST and matcher eclipse-platform/eclipse.platform.ui#4051

[vogella]

AFAIK there is no harm in merging this one, I recommend merging it to get the build green again.

[HannesWell]

To be honest I have no idea what a comparator error actually means.

It basically means that the built artifacts of a project are not binary identical to the baseline while at the same time, the source code in the project did not change respectively to be precise the version and qualifier of the artifact is the same.

I prepared the CSS spy for this by using var for the variable type.

That explains the comparator error:
The source code of the spy Plug-in didn't change while the built byte-code changed because the var variable resolved to another type.
So yes this is save to merge.

Is it possible to make this diff shown directly in some page so more people can check it?

In general this would be very convenient to have. Tycho's p2-plugin already has the writeComparatorDelta parameter.
I'll have to check if that would already be sufficient as a data-source.
I'll add it to my ToDo list. I wanted to streamline the comparator check in general anyway as it's currently quite cumbersome.