Added Find support in Plug-ins View#2343
Open
nburnwal09 wants to merge 1 commit into
Open
Conversation
nburnwal09
force-pushed
the
find_plugins
branch
2 times, most recently
from
6836fe1 to
e10b18c
Compare
|
Cool change ! |
Contributor
Author
|
@HannesWell |
noopur2507
requested changes
Jun 5, 2026
noopur2507
left a comment
noopur2507
left a comment
Member
There was a problem hiding this comment.
Hi Neha, I tried the patch and have a couple of observations:
- I notice some lag in both the filter field and the tree when typing or deleting filter text quickly.
- When filter text is present, Cmd+A does not seem to select the entire text in the filter field, which makes it difficult to clear the filter by selecting all and deleting.
Could you please take a look?
Contributor
Author
Sure Noopur. I will check. |
nburnwal09
force-pushed
the
find_plugins
branch
2 times, most recently
from
c2a5216 to
d60948b
Compare
Contributor
Author
|
Hi @noopur2507 |
This commit adds find support in plug-ins view fixes: eclipse-pde#2341
Contributor
|
For new code I suggest to use the e4 FilteredTree which is a reworked version of the old FilteredTree, should be more a less a drop-in replacement (except the, true, true parameters). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2341
Added plugin level find support in Plug-ins view
find.support.mov