Skip to content

Option to add console argument in the launch configuration#2274

Merged
merks merged 1 commit into
eclipse-pde:masterfrom
elsazac:enhancement
Jun 15, 2026
Merged

Option to add console argument in the launch configuration#2274
merks merged 1 commit into
eclipse-pde:masterfrom
elsazac:enhancement

Conversation

@elsazac

@elsazac elsazac commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds an option in launch configuration to add -console argument in program arguments.

Screenshot 2026-03-25 at 1 50 47 PM

Screenshot 2026-03-25 at 12 04 18 PM

Screenshot 2026-03-25 at 12 07 10 PM

Fixes : #1851

laeubi
laeubi reviewed Mar 25, 2026
View reviewed changes

@laeubi laeubi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this this looks very promising!

Comment thread ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties Outdated
@github-actions

github-actions Bot commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

  126 files  ±0    126 suites  ±0   42m 57s ⏱️ + 6m 46s
3 516 tests ±0  3 462 ✅ ±0   54 💤 ±0  0 ❌ ±0 
9 351 runs  ±0  9 221 ✅ ±0  130 💤 ±0  0 ❌ ±0 

Results for commit ca6499a. ± Comparison against base commit c15b81c.

♻️ This comment has been updated with latest results.

@elsazac elsazac force-pushed the enhancement branch 6 times, most recently from 786d9ca to 7049ed5 Compare March 25, 2026 07:36
@elsazac

elsazac commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@merks Could you please help review and merge this PR?

merks
merks reviewed Jun 9, 2026
View reviewed changes
Comment thread ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/launcher/ProgramBlock.java Outdated
@elsazac elsazac force-pushed the enhancement branch 4 times, most recently from f5be9dd to c17e683 Compare June 10, 2026 18:18
@eclipse-pde-bot

eclipse-pde-bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From c5e494ddb6530edab56cff4101df83c7e88720c5 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Wed, 10 Jun 2026 18:31:32 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
index ddaa9c6ccc..70ffb34252 100644
--- a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.ui; singleton:=true
-Bundle-Version: 3.16.500.qualifier
+Bundle-Version: 3.16.600.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ui.PDEPlugin
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@elsazac elsazac force-pushed the enhancement branch 2 times, most recently from 567ca47 to 6513173 Compare June 10, 2026 18:35
@elsazac

elsazac commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

The failures are unrelated to this PR.

@elsazac

elsazac commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@merks The changes have been addressed. Could you please have a quick look when convenient and let me know if there's anything else that needs to be updated?.

merks
merks reviewed Jun 12, 2026
View reviewed changes

@merks merks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just really small nitty things. Otherwise good.

Comment thread ui/org.eclipse.pde.launching/src/org/eclipse/pde/launching/IPDELauncherConstants.java Outdated
Comment thread ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/launcher/ProgramBlock.java Outdated
@elsazac elsazac force-pushed the enhancement branch 2 times, most recently from 8b186ff to 5101afe Compare June 12, 2026 10:58
@elsazac elsazac changed the title Add option to add console argument in the launch configuration Option to add console argument in the launch configuration Jun 12, 2026
merks
merks approved these changes Jun 12, 2026
View reviewed changes

@merks merks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@elsazac elsazac force-pushed the enhancement branch 4 times, most recently from bbb49d0 to 6e305ad Compare June 15, 2026 11:16
@elsazac

elsazac commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

@merks Would you mind merging this when its convenient ?

@elsazac
Option to add console argument in the launch configuration
ca6499a 
This commit adds an option in launch configuration to add -console
argument in program arguments.

Fixes : eclipse-pde#1851
@merks

merks commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

The failures look unrelated to the changes.

@merks merks merged commit d9e9bc8 into eclipse-pde:master Jun 15, 2026
16 of 19 checks passed
@elsazac

elsazac commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

@merks thank you very much for taking the time to review and merge this.

@MohananRahul MohananRahul mentioned this pull request Jun 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laeubi laeubi laeubi left review comments

@merks merks merks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create an Launch Configuration option to show the OSGi Console

4 participants

@elsazac @eclipse-pde-bot @merks @laeubi