Placeholders#35
Open
benjaminpg wants to merge 6 commits into
Open
Conversation
added 6 commits
February 26, 2016 12:24
…ires no translations, such as numbers, names, dates) within message. TODO: create test for this feature and include in demo.
… uses an i18n message with placeholders and bindings.
ebidel
force-pushed
the
master
branch
3 times, most recently
from
2ca7d06 to
5263fa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I rewrote my code according to your suggestion of using chrome.i18n API and this time I managed to not only make it works alike but include a demo and a couple of test. In case you don't remember: #33
The placeholders parameter receives an array with the values to be used and includes a listener.
Thanks!
Benjamin