coupling prom and magpie implemented#97
Conversation
| # ├── Secondary Forest | ||
| # └── Timber Plantations | ||
| # ============================================================================ | ||
| emi_vars <- c( |
There was a problem hiding this comment.
All these variables it is better to have it in csv file that we can easily alter instead of being hardcoded.
There was a problem hiding this comment.
agree, shall I create a csv file including the variable names in postprom/inst/extdata? Is that the place to save such info?
alextsimp
left a comment
There was a problem hiding this comment.
Please use camelCase in all R scripts. It is the coding standard.
…tprom into auto-prom-magpie
…e and update variable names for bottom-up aggregation Co-authored-by: Copilot <copilot@github.com>
… and enhance unit extraction for gases Co-authored-by: Copilot <copilot@github.com>
…CH4/N2O emissions extraction
…s data and improve variable naming
|
Looks good. I have a few suggestions:
|
|
Thanks @mmadianos ! I have improved the script following your first comment. Now the weights are hard-coded in the script since it is not long. It is better in this way, expecially for external users, that the script doesn't depend on the access of Climate Watch data. I also kept the script to generate these values, in case we want to change the methodology and refresh it. Furthermore, I also improved the disaggregation methodology by taking into account the cluster heterogeneity in MAgPIE, but you don't need to review this. I have tested. Once @alextsimp and you have an agreement on the second comment, you can close the PR and I will merge it. Thanks a lot! |
…nd introduce prepareMagpieAfolu helper function
|
I made it a bit more cleaner so I think now we can merge it. @SongminYu @mmadianos |
introduced in the open-prom PR