Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3551
This PR:
scheduled_tasks/instances.pyfor easier migration to pipelines.InstancePipeline.FleetPipelineto respect instance locks.FleetModel.current_master_instance_idcolumn for cloud clusters. Implements current master instance selection logic inFleetPipeline. Updates instance provisioning logic to useFleetModel.current_master_instance_id. (This fixes a race condition with updating siblings in case of master failure and allows re-selecting master.)Benchmarks (SQLite, one server replica):
workers_num * processing_rate, e.g. typically 600-1200 instances/min for check instances depending on check network latency. With many resources, all processing including termination becomes ~10x faster.workers_num.Notes:
lock_timeouterrors occur on SQLite even with very high write load due to pipelines using quick sessions only.