Skip to content

[UI]: Implement dynamic property filter options#3621

Merged
olgenn merged 3 commits intomasterfrom
3473_dynamic_property_filter_options
Mar 5, 2026
Merged

[UI]: Implement dynamic property filter options#3621
olgenn merged 3 commits intomasterfrom
3473_dynamic_property_filter_options

Conversation

@olgenn
Copy link
Collaborator

@olgenn olgenn commented Feb 26, 2026

@olgenn olgenn self-assigned this Feb 26, 2026
setFilteringStatusType('loading');

if (filteringProperty?.key === filterKeys.PROJECT_NAME) {
await getProjects({ name_pattern: filteringText })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI should set some sensible limit in filters, e.g. 100 – the default server limit is large (2000) for backward compatibility.

@peterschmidt85
Copy link
Contributor

@olgenn If Victor tested it, we can merge

Copy link
Collaborator

@jvstme jvstme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olgenn, I tested event filters, found these issues:

  • The Target projects, Within projects, Target users, and Actors filters on the Events page switch from names to IDs in a weird way (as you've mentioned yourself). This is a regression, so it'd be good to fix it. But if there isn't a simple fix, I personally don't mind keeping it as is.

    Image

  • The Events tabs on Project and User pages don't work. They attempt to set within_projects, actors, and target_users to names instead of IDs, which fails with error 422.

@olgenn
Copy link
Collaborator Author

olgenn commented Mar 4, 2026

@jvstme I fixed second point

@olgenn olgenn merged commit 98fc29b into master Mar 5, 2026
28 checks passed
@olgenn olgenn deleted the 3473_dynamic_property_filter_options branch March 5, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants