fix: INF-667 fetch GitHub release assets via api.github.com (avoids web-tier 504s)#78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PharInstaller::download()fetched release binaries (e.g.local-php-security-checker) with a barefile_get_contents()against thegithub.comweb tier. That tier intermittently returns edge 504s for some CI egress IPs and applies stricter unauthenticated limits — which brokecomposer install/ Docker builds on ci2 (see INF-667).Fix
Route
https://github.com/<o>/<r>/releases/download/...URLs through theapi.github.comrelease-asset endpoint instead — a different, healthy host whose*.githubusercontent.comasset CDN is independent of the failing web tier.api.github.com, then downloads the matching asset.github-oauthtoken Composer already holds when present (relaxes the anonymous rate limit), but works fully unauthenticated too — important for builds that have no token configured.Authorizationheader (the API 302-redirects to a pre-signed CDN URL that rejects an extra auth header; these tools live in public repos).github.comURL on any failure, with a small retry/backoff — so behaviour is never worse than before.Ref: INF-667. Mirrors drunomics/ldp-project#2731.
🤖 Generated with Claude Code