Skip to content

Merge build logs instead of append it#338

Open
wingyplus wants to merge 1 commit intodrone:mainfrom
wingyplus:merge-log
Open

Merge build logs instead of append it#338
wingyplus wants to merge 1 commit intodrone:mainfrom
wingyplus:merge-log

Conversation

@wingyplus
Copy link
Copy Markdown

@wingyplus wingyplus commented Aug 13, 2020

Sometimes server sent build log event since first line and drone-ui
append to the old build log. This approach make a user see a build since
first line again even it already shown. Fix it by merge a new logs to
the old logs by using field "pos" as a array index.

This is an example:

Screen Shot 2563-08-13 at 18 38 47

NOTE: I cannot show the full log because it's secret.

Sometimes server sent build log event since first line and drone-ui
append to the old build log. This approach make a user see a build since
first line again even it already shown. Fix it by merge a new logs to
the old logs by using field "pos" as a array index.
@wingyplus
Copy link
Copy Markdown
Author

@bradrydzewski Love to see if you've any suggestions. :)

@wingyplus wingyplus changed the title Merge build logs instead of concatinate it Merge build logs instead of append it Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants