Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates remote board execution so
ostoolexits with an error whenostool-serverreleases the session or closes the serial websocket.It applies the same handling to both direct board serial terminals and the remote U-Boot serial bridge used by
ostool board.Why
Previously, server-side
closedand related websocket termination paths could be treated like a normal terminal shutdown on the client side.That made
ostoollook like it ended cleanly even though the board session had actually been released byostool-server.Impact
When the server frees the board or tears down the serial websocket, the local
ostoolcommand now reports an error and exits.This makes remote board session loss visible to users and to automation.
Validation
cargo test -p ostool