fix(uboot): honor board timeout in serial interaction stage#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates board-driven U-Boot timeout handling so
.board.tomltimeoutis propagated into the U-Boot runtime config.It also keeps the timeout semantics aligned with the existing terminal behavior: the timeout starts when the serial terminal interaction stage begins, not during earlier U-Boot setup, probing, or image staging.
Why
ostool boarddid not honor the configured timeout becauseBoardRunConfigwas not carryingtimeoutintoUbootConfig.That meant board runs silently ignored the timeout value even though direct U-Boot config parsing already supported it.
Impact
Users running
ostool boardcan now configuretimeoutin.board.tomland have it take effect consistently.The countdown starts from the later serial interaction stage, which matches the existing behavior of the terminal runner.
Validation
cargo test -p ostool