Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
TransferKind::Isochronousinstead of only storing a packet countsubmit_with_packet_lengthshelpers for isochronous endpoints while keeping the even-split fallback APIDeviceInfo::id()for callers that need a stable device identifierWhy
Some isochronous workloads need uneven packet sizing, but the previous transfer model only kept
num_pkgsand then recomputed even slices in each backend. That could not represent variable packet layouts correctly.Impact
num_packetsstill work through the even-split helperValidation
cargo fmt --checkcargo check -p crab-usb --libcargo check -p crab-uvc --libcargo test -p crab-usb -p crab-uvcbut it still fails in pre-existingcrab-uvctests/examples (VideoFormat::*variant resolution and missingUSBHost::new_libusb), unrelated to this diff