Skip to content

fix: gemma-4 inference with Pipeline Parallelism #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlpinDale wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: gemma-4 inference with Pipeline Parallelism #1663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions aphrodite/model_executor/models/gemma4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,8 +1218,8 @@ def forward(
else:
assert intermediate_tensors is not None
hidden_states = intermediate_tensors["hidden_states"]
residual = intermediate_tensors["residual"]
per_layer_inputs = intermediate_tensors.get("per_layer_inputs")
residual = intermediate_tensors.tensors.get("residual")
per_layer_inputs = intermediate_tensors.tensors.get("per_layer_inputs")

aux_hidden_states = self._maybe_add_hidden_state([], 0, hidden_states, residual)
for layer_idx, layer in enumerate(islice(self.layers, self.start_layer, self.end_layer)):
Expand All @@ -1238,13 +1238,12 @@ def forward(
)
self._maybe_add_hidden_state(aux_hidden_states, layer_idx + 1, hidden_states, residual)
if not get_pp_group().is_last_rank:
return IntermediateTensors(
{
"hidden_states": hidden_states,
"residual": residual,
"per_layer_inputs": per_layer_inputs,
}
)
tensors = {"hidden_states": hidden_states}
if residual is not None:
tensors["residual"] = residual
if per_layer_inputs is not None:
tensors["per_layer_inputs"] = per_layer_inputs
return IntermediateTensors(tensors)
# Gemma4 incorporates residual into hidden_states directly
# Apply norm without residual fusion when possible.
if residual is None:
Expand Down
Loading