feat(Button): add release OnClickWithouRender reference

[ArgoZhang]

Link issues

fixes #7891

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

• Clear the OnClickWithoutRender callback when disposing a button component to prevent stale event handler references.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures ButtonBase clears the OnClickWithoutRender callback reference during asynchronous disposal to prevent lingering event handlers or memory leaks.

Class diagram for updated ButtonBase disposal behavior

classDiagram
    class ButtonBase {
        +bool IsAsync
        +EventCallback OnClick
        +EventCallback OnClickWithoutRender
        +ValidateFormComponent ValidateForm
        +ValueTask DisposeAsync(bool disposing)
    }

    class ValidateFormComponent {
        +void UnregisterAsyncSubmitButton(ButtonBase button)
    }

    ButtonBase --> ValidateFormComponent : uses

Loading

Flow diagram for ButtonBase.DisposeAsync with OnClickWithoutRender clearing

flowchart TD
    A[DisposeAsync disposing == true] --> B{OnClick != EventCallback.Empty?}
    B -- yes --> C[Set OnClick to EventCallback.Empty]
    B -- no --> D[Skip clearing OnClick]
    C --> E{OnClickWithoutRender != null?}
    D --> E
    E -- yes --> F[Set OnClickWithoutRender to null]
    E -- no --> G[Skip clearing OnClickWithoutRender]
    F --> H{IsAsync == true and ValidateForm != null?}
    G --> H
    H -- yes --> I[ValidateForm.UnregisterAsyncSubmitButton this]
    H -- no --> J[Skip unregister]
    I --> K[Continue disposal]
    J --> K[Continue disposal]

Loading

File-Level Changes

Change	Details	Files
Clear OnClickWithoutRender callback during component disposal to avoid retaining event handler references.	Add null-check for OnClickWithoutRender in DisposeAsync Assign OnClickWithoutRender to null when the component is disposing	src/BootstrapBlazor/Components/Button/ButtonBase.cs

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#7891	Ensure that the Button component releases/clears its OnClickWithoutRender reference during disposal to avoid holding stale references (e.g., potential memory leaks).	✅

Possibly linked issues

• feat(Button): add release OnClickWithouRender reference #7891: PR disposes the OnClickWithoutRender reference exactly as requested in the feature issue for Button.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• For consistency with the existing OnClick cleanup, consider resetting OnClickWithoutRender in the same style (e.g., to an appropriate empty/default callback) rather than just setting it to null, assuming it is also an EventCallback or similar delegate.
• The null check before OnClickWithoutRender = null; is redundant; you can safely assign null directly without the conditional block.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- For consistency with the existing `OnClick` cleanup, consider resetting `OnClickWithoutRender` in the same style (e.g., to an appropriate empty/default callback) rather than just setting it to `null`, assuming it is also an `EventCallback` or similar delegate.
- The null check before `OnClickWithoutRender = null;` is redundant; you can safely assign `null` directly without the conditional block.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull request overview

This PR updates the ButtonBase component cleanup logic to explicitly release the OnClickWithoutRender delegate reference during disposal, aligning with the goal of reducing retained references after a button is removed.

Changes:

• Clear OnClickWithoutRender in DisposeAsync to release the delegate reference when the component is disposed.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3c888bf) to head (1a52a0f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #7892   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          764       764           
  Lines        34173     34177    +4     
  Branches      4702      4703    +1     
=========================================
+ Hits         34173     34177    +4     

Flag	Coverage Δ
BB	100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.