chore: Remove unneeded project reference from auto-generated project#3171
chore: Remove unneeded project reference from auto-generated project#3171filzrev wants to merge 1 commit into
Conversation
|
When I tried it originally the disassemble tests failed. Maybe that was fixed with clrmd v4. [Edit] Actually, I see the tests are still failing on arm. |
|
Disassembler tests on It's occurred because DllGatherer add And as far as I've confirmed. @timcassell |
|
It's to resolve issues with dll references that weren't picked up by the auto-generated project previously (see the linked issues that #2508 closed). If you have a better solution for it, please send a PR. 😄 |
|
I see the reference gatherer only gets the top directory files, not nested directories. Maybe we simply need to pass |
This PR remove
ProjectReferenceof benchmark project fromBenchmarkDotNet.Autogenerated.csprojCsProjGenerator gather referenced dlls of benchmark project.
Then add referenced dlls as
<Reference Include="..." />node.So original
<ProjectReference Include="..." />node is not expected to be used when buildingBenchmarkDotNet.Autogenerated.csprojTest
This code path is not used when running IntegrationTest project or when using non Release custom configuration.
BenchmarkDotNet/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommand.cs
Line 57 in bcdcc98
So I've confirmed behavior by using generated
binlog.After this PR content is merged. Reference project evaluation stage is skipped on local build.