Improve 11.0 P4 coverage#37160
Open
guardrex wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves ASP.NET Core 11 Preview 4 documentation coverage, primarily for Blazor release notes, and updates OpenTelemetry terminology in related docs.
Changes:
- Expands Blazor 11.0 release note coverage for Web Worker, virtualization, Gateway, and WebAssembly trimming updates.
- Updates OpenTelemetry naming/linking in YARP distributed tracing and Blazor tooling docs.
- Refreshes the ASP.NET Core 11 release notes
ms.date.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
aspnetcore/release-notes/aspnetcore-11/includes/blazor.md |
Expands Blazor Preview 4 release note content and resource links. |
aspnetcore/release-notes/aspnetcore-11.md |
Updates release notes metadata date. |
aspnetcore/fundamentals/servers/yarp/distributed-tracing.md |
Updates OpenTelemetry terminology and links. |
aspnetcore/blazor/tooling.md |
Updates OpenTelemetry/OTLP wording for the service defaults template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37156
Tom, Wade ... Just need one review to get this set of improvements in. I found some content that Copilot generated that I liked for improvements to the What's New coverage.
Ilona ... No need to review the whole thing, but a quick ❓🏃♀️ for ya ... When Copilot wrote that the .NET Web Worker (old name)/Blazor Web Worker (new name) project template is also for Blazor Web Apps, I assume that it meant for the
.Client(CSR) side of a BWA. Is that correct? If so, I think I did a little better with phrasing than what Copilot produced by going with an opening line of ...Does that look good to you, or would you like to change it?
Also ...... 🙈 ..... one more ❓... Dan and I are concerned about cross-linking PU issues/PRs due to developers bikeshedding comments ... commenting on closed issues/PRs. On this PR, I did what Copilot did for a number of the new features by adding the PU PR cross-link, which can be helpful to devs looking for more details. I do not do that in the article content tho, just in the What's New content. I place the remark, "(Please don't comment on closed issues and PRs)," on every link that I place. Do you think that's ok in this case? ... and indeed, Copilot did do that over in the .NET release note doc. If you think it's going to end in tears 😢 for the team with folks commenting on your closed issues/PRs, then I think I should remove these PU PR links here. Perhaps, Copilot should be instructed to stop doing it over there, too.
Internal previews