Light Freshness: ASP.NET - 6 Security/Auth topics#37148
Conversation
|
Hi @wadepickett - Refreshed topics ready for your review. See the top comment for details. Notes:
Thanks |
| [!code-csharp[](~/security/authentication/claims/sample8/WebRPmapClaims/Program.cs?name=snippet_NS8&highlight=20)] | ||
|
|
||
| ## Extend or add custom claims using `IClaimsTransformation` | ||
| ## Extend or add custom claims using 'IClaimsTransformation' |
There was a problem hiding this comment.
| ## Extend or add custom claims using 'IClaimsTransformation' | |
| ## Extend or add custom claims using `IClaimsTransformation` |
Code identifier and should have backticks per repo guidelines.
There was a problem hiding this comment.
The editorial instructions say not to overload formatting in headers, i.e., don't apply both bold (from the header H2) and also inline code - which is why I swapped the code ticks for single quotes.
| @@ -1,92 +1,93 @@ | |||
| --- | |||
| title: Enable QR code generation for TOTP authenticator apps in ASP.NET Core | |||
| title: Enable QR code generation for TOTP authentication | |||
There was a problem hiding this comment.
| title: Enable QR code generation for TOTP authentication | |
| title: Enable QR code generation for TOTP authenticator apps in ASP.NET Core |
I think it is best in this case to leave "ASP.NET Core" in there to differentiate from similar topics that are not using this framework.
There was a problem hiding this comment.
The metadata criteria indicates the title attribute length should be 50 characters or less, which is why I made the adjustments. The publishing system essentially limits chars to 50 in the title proper. However, if the titleSuffix attribute is present, the total allowed chars increases to 65. You could add "ASP.NET Core" in the metadata titleSuffix. The preview text in search results would render as "Enable QR code generation for TOTP authentication - ASP.NET Core" - Here's the criteria: Metadata required for content > title and Rules for writing meta titles. I don't usually automatically add an article-level titleSuffix because sometimes the repo defines the attribute at the folder level or repo-level in a build JSON (docfx.json or similar).
wadepickett
left a comment
There was a problem hiding this comment.
Approved, assuming the few minor items I suggested are fixed.
Great work.
@tdykstra, leaving this unmerged for a while so you can have a chance to review as well.
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
|
@wadepickett - Thank you for your review. I applied most of your suggestions. For two edits, I left you return comments. Also, I wanted to confirm that you saw my note to you in the top comment about clarity for instances of this in the text. You addressed one instance in your notes, but not all. Just confirming the other text is clear as-is. |
This PR contains light freshness updates to 6 articles:
moniker range=">= aspnetcore-8.0")moniker range=">= aspnetcore-6.0")moniker range=">= aspnetcore-9.0")-- Also updated 1 include
-- Section Example: OpenID Connect Duende IdentityServer server
There are several instances of the term "this" that need context for clarity:
Displays if the Identity comes from an app that requires MFA, but the user hasn't activated this in Identity
Informs the user and adds a link to activate this
Because the client sent this with
mfaset, this can then be checkedFor details, see ADO request 568764.
Internal previews