Skip to content

feat: claim by mail#172

Open
Hladikes wants to merge 1 commit into
mainfrom
feature/claim/by-mail-new
Open

feat: claim by mail#172
Hladikes wants to merge 1 commit into
mainfrom
feature/claim/by-mail-new

Conversation

@Hladikes

Copy link
Copy Markdown
Collaborator

No description provided.

@vercel

vercel Bot commented Feb 23, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dotpoap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2025 11:25pm

@Hladikes Hladikes marked this pull request as ready for review March 18, 2025 11:49
@Hladikes Hladikes requested a review from bran0h March 18, 2025 11:49
@Hladikes Hladikes changed the base branch from main to feature/manage-memos March 18, 2025 14:19
Comment thread pages/claim/[code].vue
</template>

<template v-if="reserved">
<!-- TODO make successful reservation specific UI ? -->

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

const query = getQuery(event);

const [rawData, err] = await $fetch<Reservation>(
`${RUNTIME_CONFIG.apiUrl}/poaps/${query.code}/reservation/${query.reservation}`,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST should be formed in plural for each entity /poaps/1/reservations/2

.catch((r) => [null, r]);

if (!verificationErr) {
throw createError({ statusMessage: "E-mail not verified, check your inbox" });

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add status codes

Base automatically changed from feature/manage-memos to main September 10, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants