fix: strip leading dots and hyphens from raw tags#646
Open
zry98 wants to merge 1 commit intodocker:masterfrom
Open
fix: strip leading dots and hyphens from raw tags#646zry98 wants to merge 1 commit intodocker:masterfrom
zry98 wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: zry98 <dev@zry.io>
zry98
force-pushed
the
fix/raw-tag-sanitizing
branch
from
c13d8ec to
bd9134e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Docker image tag reference, the format is
/[\w][\w.-]{0,127}/, a dot (.) or hyphen (-) is not allowed as a leading character.sanitizeTag()was already replacing illegal characters from the middle of tag names, but not for the leading characters. A given raw tag like.foo\barwould be sanitized to.foo-bar, instead offoo-bar.This PR added a second regex replacement pass
.replace(/^[^a-zA-Z0-9_]+/, '')to strip any leading dots or hyphens.Also added 3 related tests.