doc: document {ORIGINAL_INSTRUCTIONS} placeholder for toolset instructions#2062
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 11, 2026
Conversation
…tions
Update the agent-schema.json description for the toolset instruction field
(both Toolset and MCPToolset) to explain that {ORIGINAL_INSTRUCTIONS} can
be used to enrich built-in instructions rather than replacing them.
Add examples/toolset_instructions.yaml demonstrating the three patterns:
enrich by appending, enrich by prepending, and full replacement.
Add the new example to examples/README.md.
Assisted-By: docker-agent
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This documentation PR cleanly adds the {ORIGINAL_INSTRUCTIONS} placeholder feature to the schema and provides clear examples.
Analysis
Schema Changes (agent-schema.json):
- Updated
instructionfield descriptions for bothToolsetandMCPToolset - Descriptions are clear, consistent, and explain the placeholder behavior with examples
- JSON syntax is valid
Example (toolset_instructions.yaml):
- Demonstrates all three usage patterns (prepend, append, replace)
- YAML is well-structured with helpful comments
- Consistent with the schema documentation
Documentation (examples/README.md):
- Correctly adds the new example to the table
Findings
✅ No bugs found. The changes are documentation-only and correctly implement the feature description.
Automated review by docker-agent
Member
Author
|
cc @k33g |
trungutt
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document how to use
{ORIGINAL_INSTRUCTIONS}in a toolsetinstructionfield to enrich the built-in instructions rather than replacing them.Changes
instructionfield description for bothToolsetandMCPToolsetto explain the{ORIGINAL_INSTRUCTIONS}placeholder and its behavior.