Fix potential nil pointer dereference when checking container state in Remove#13556
Open
Nepomuk5665 wants to merge 1 commit intodocker:mainfrom
Open
Fix potential nil pointer dereference when checking container state in Remove#13556Nepomuk5665 wants to merge 1 commit intodocker:mainfrom
Nepomuk5665 wants to merge 1 commit intodocker:mainfrom
Conversation
…n Remove Add nil check for inspected.State before accessing inspected.State.Running in the Remove function. This is consistent with nil checks done elsewhere in the codebase (convergence.go, monitor.go, ps.go) and prevents a potential panic if Docker returns a container without State information. Signed-off-by: Nepomuk Crhonek <105591323+Nepomuk5665@users.noreply.github.com>
fc08ec9 to
46936f6
Compare
ndeloof
approved these changes
Jan 26, 2026
glours
approved these changes
Jan 26, 2026
Contributor
|
add nolint:gogyclo on this function, we can look into refactoring to make code simpler in a follow-up PR |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inspected.Statebefore accessinginspected.State.Runningin theRemovefunctionProblem
In
pkg/compose/remove.go:67, the code accessesinspected.State.Runningwithout first checking ifinspected.Stateis nil:While Docker containers typically always have State populated, this is inconsistent with nil checks done elsewhere in the codebase and could cause a panic in edge cases (race conditions, unusual Docker states, or API changes).
Solution
Add a nil check consistent with the pattern used elsewhere in the codebase:
pkg/compose/convergence.go:836-ctr.State != nil && ctr.State.Statuspkg/compose/convergence.go:862-ctr.State != nil && ctr.State.Statuspkg/compose/monitor.go:150-inspect.State != nil && (inspect.State.Restarting || ...)pkg/compose/ps.go:70-if inspect.State != nil {The fix adds a nil check that treats containers with nil State as "stopped" (which is the safe default for the Remove operation).