history: finalize export records on their owning node#3716
Open
crazy-max wants to merge 4 commits intodocker:masterfrom
Open
history: finalize export records on their owning node#3716crazy-max wants to merge 4 commits intodocker:masterfrom
crazy-max wants to merge 4 commits intodocker:masterfrom
Conversation
Member
Author
|
Hum still fails, looking at the logs: https://github.com/docker/buildx/actions/runs/22947651040/job/66604243143?pr=3716#step:9:321
|
bfa30ad to
7b2fc84
Compare
crazy-max
commented
Mar 11, 2026
7b2fc84 to
c08d761
Compare
crazy-max
commented
Mar 11, 2026
c08d761 to
546ef34
Compare
b8b84bf to
a3f74ef
Compare
9bf67d2 to
ba2f865
Compare
51f5b32 to
3a4686a
Compare
31ed9f1 to
be4a2c2
Compare
Member
Author
|
Tried to add integration tests but can't make it works with docker runtime atm: https://github.com/docker/buildx/actions/runs/22994422408/job/66762935425#step:7:2418 Will work on multi-nodes support in our integration tests as follow-up: crazy-max@35166b9 Edit: opened #3724 and rebased on top of it |
0c6e103 to
6d100df
Compare
33926f5 to
3675c74
Compare
5095d06 to
e0b8929
Compare
tonistiigi
reviewed
Mar 12, 2026
e0b8929 to
8b1bba8
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
8b1bba8 to
3fc8c06
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
3fc8c06 to
363853f
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs #3724fixes docker/build-push-action#1388
closes #3344
closes docker/build-push-action#1392
closes docker/bake-action#336
This fixes
history export --finalizefor multi-node builders such as the Kubernetes driver.The failure happens when the same logical build ref appears more than once in history, once per node, and export finalization is not applied to the node that owns the selected record. In that case Buildx can later try to export a record whose trace descriptor is still not readable and fail with
NotFoundwhile loading the trace descriptor:This keeps the existing finalize behavior for records that do not yet expose a trace descriptor, but changes finalization to follow record ownership. Buildx now deduplicates selected records by (ref, node), sends finalize to the owning node for each selected record, re-queries records before export, and collapses duplicate per-node entries down to one logical record per ref.
It also fixes bundle export to use all available node content stores instead of stopping at the first one. That allows the exported records to resolve their referenced content correctly across multi-node builders during archive creation.