Added a helper function and updated the existing methods to preserve edge weights when removing vertices, edges or copying digraphs (issue #683)#877
Open
devansh2605 wants to merge 19 commits intodigraphs:mainfrom
Conversation
…edge weights when removing vertices, edges or copying digraphs (issue digraphs#683)
Collaborator
|
This looks like it's coming along. Could you please:
It'd be great if you could do this by next meeting, so we can do a proper review of your two PRs. |
mtorpey
reviewed
Nov 10, 2025
Collaborator
|
Looks like linting is improved! If you could now add tests, that should satisfy the codecov check. |
…igraphRemoveVertex and related immutable operations. Also added testing.
mtorpey
reviewed
Nov 24, 2025
Collaborator
mtorpey
left a comment
mtorpey
left a comment
There was a problem hiding this comment.
Subject to what we've said above, it'd be nice to see documentation. But this is coming along well.
Collaborator
|
Documentation should be installed in doc/z-chap5.xml |
…the weights correctly. Split the DigraphImmutableCopy into a helper DigraphImmutableCopyNoWeights to copy the weights correctly.
Contributor
Author
|
@mtorpey I have added edge-weighted to the failing tests but the |
mtorpey
reviewed
Dec 10, 2025
doc/digraph.xml
Outdated
| digraph. <P/> | ||
|
|
||
| This can be useful when modifying the structure of a digraph with | ||
| <Ref Oper="DigraphRemoveVertex"/> or <Ref Oper="DigraphRemoveEdge"/>, |
Collaborator
There was a problem hiding this comment.
I think this last reference needs to be
<Ref Oper="DigraphRemoveEdge" Label="for a digraph and an edge"/>
to allow the manual tests to pass.
Contributor
Author
There was a problem hiding this comment.
Added the label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue -
https://github.com/digraphs/Digraphs/issues/683Previously, deleting vertices or edges from an EdgeWeightedDigraph or taking a mutable copy caused the resulting digraph to lose its edge weights. This commit is just a layout for which I'll add tests and debug.
Changes include:
CopyEdgeWeightsForSubdigraphhelper function to reconstruct weights after vertex removals.DigraphRemoveVertexto copy edge weights.DigraphRemoveEdgeto remove corresponding weight entries instead of dropping all weights.DigraphMutableCopyto copy edge weights when present.digraph.gd.