Prepare first stable release gates#134
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares the repo for the first stable (non-prerelease) release by tightening “release gate” hygiene across the website dependency audit, CLI help/security documentation, release notes, and CI/docs validation.
Changes:
- Website: add an
esbuildoverride and refresh the lockfile (including@astrojs/starlight+ related transitive updates) to satisfy npm audit gates. - CLI/help + notes: document the
view --share-bindraw TCP trust boundary and add stable release notes used by the release workflow. - Tests/docs tooling: update the portable CI bash tutorial test to prefer Git Bash on Windows and refresh the repo-local agent skill selector example.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/package.json | Adds an npm override to pin esbuild for audit gating. |
| website/package-lock.json | Lockfile refresh to apply the override and dependency bumps. |
| Luotsi.Cli/Cli/Help.cs | Documents --share-bind sharing trust boundary in help view. |
| Luotsi.Cli.Tests/TutorialDocumentationTests.cs | Prefers portable Git Bash on Windows for the portable CI bash script test. |
| .github/release-notes/stable.md | Adds stable-release notes consumed by the release workflow. |
| .codex/skills/luotsi-agent/references/agent-loop.md | Replaces a branded selector example with a generic one. |
Files not reviewed (1)
- website/package-lock.json: Generated file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuildto0.28.1, refreshing the lockfile, and picking up@astrojs/starlight0.39.3view --share-bindraw TCP trust boundary in CLI helpValidation
dotnet restore .\Luotsi.sln --locked-modedotnet build .\Luotsi.sln --configuration Release --no-restore --warnaserrordotnet test .\Luotsi.Cli.Tests\Luotsi.Cli.Tests.csproj --filter "FullyQualifiedName~Command_Reference_Documents_Known_Command_And_Help_Surfaces|FullyQualifiedName~Website_Documentation_Links_Resolve|FullyQualifiedName~Website_Documentation_Sidebar_Slugs_Resolve"dotnet test .\Luotsi.Cli.Tests\Luotsi.Cli.Tests.csproj --configuration Release --filter "FullyQualifiedName~Portable_Ci_Bash_Script_Preserves_Run_Failure_And_Appends_Checked_Run_Summary"dotnet test .\Luotsi.sln --configuration Release --no-builddotnet list .\Luotsi.sln package --vulnerable --include-transitivecd website; cmd.exe /c npm.cmd cicd website; cmd.exe /c npm.cmd auditcd website; cmd.exe /c npm.cmd run checkcd website; cmd.exe /c npm.cmd run builddotnet run --project .\Luotsi.Cli\Luotsi.Cli.csproj -- help view | Select-String -Pattern "share-bind|raw TCP|TLS|authentication|untrusted" -Context 1,2Notes:
esbuildDependabot alert until this reachesmain.Remaining first stable release gates
mainv0.1.0, from greenmainhttps://github.com/digablesolutions/luotsi/releases/latest/download/luotsi-install.ps1and.shreturn 200 after the stable release existsSigning secret check was run separately against GitHub Actions secrets; the expected Android release signing secret names are present.