Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor to the build system and project structure, focusing on modularizing the codebase and improving library management. It adds new CMake options for building separate serializer and converter libraries, restructures how libraries are defined and linked, and introduces a new
.clang-formatconfiguration. Additionally, it removes several converter-related header files, indicating a possible migration or redesign of converter functionality.Build system and project structure improvements:
OPENDSPX_BUILD_SERIALIZERandOPENDSPX_BUILD_CONVERTERto support building serializer and converter libraries separately.CMakeLists.txtto modularize library creation, introduce macros for adding libraries, and update linking and installation logic. This includes the creation ofmodel,serializer, andconvertertargets, and improved handling of platform-specific resources.add_winrc) incmake/winrc.cmaketo accept parameters for name, description, and copyright, and applied it to the new modular targets. [1] [2] [3]Code formatting and standards:
.clang-formatconfiguration file to standardize C++ code formatting across the project.Converter functionality changes:
include/opendspx/converter.h,include/opendspx/converters/midi.h,include/opendspx/converters/opensvip.h,include/opendspx/converters/svip.h,include/opendspx/converters/ust.h), suggesting a redesign or relocation of converter logic. [1] [2] [3] [4] [5]These changes collectively enhance the maintainability, modularity, and build flexibility of the project.