Skip to content

Fix Dashlane Cloudflare captcha by implementing official CLI protocol#185

Merged
detunized merged 8 commits into
masterfrom
issue-180
Sep 27, 2025
Merged

Fix Dashlane Cloudflare captcha by implementing official CLI protocol#185
detunized merged 8 commits into
masterfrom
issue-180

Conversation

@detunized

Copy link
Copy Markdown
Owner

Fixes #180

The old Dashlane protocol was triggering Cloudflare captcha protection, which returned HTML instead of JSON and caused parsing errors.

This PR implements a new protocol that mimics the official Dashlane CLI to avoid triggering captcha protection.

Changes

  • Reworked Dashlane client to use official CLI protocol
  • Added proper MFA retry logic with better error messages
  • Improved test coverage for authentication flows

@gitguardian

gitguardian Bot commented Sep 27, 2025

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
21216985 Triggered Generic High Entropy Secret 884166d test/Dashlane/Fixtures/perform-totp-verification.json View secret
21216986 Triggered Generic High Entropy Secret 884166d test/Dashlane/Fixtures/complete-device-registration-with-server-key.json View secret
21216987 Triggered Generic High Entropy Secret 884166d test/Dashlane/Fixtures/complete-device-registration-with-auth-ticket.json View secret
21216988 Triggered Generic High Entropy Secret 884166d test/Dashlane/Fixtures/complete-device-registration-with-server-key.json View secret
21216989 Triggered Generic High Entropy Secret 884166d test/Dashlane/VaultTest.cs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@detunized detunized merged commit 0d40dae into master Sep 27, 2025
12 checks passed
@detunized detunized deleted the issue-180 branch September 27, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashlane: invalid JSON in response

1 participant