Skip to content

Update to the latest agents#96

Merged
Malcolmnixon merged 3 commits into
mainfrom
update-agents
Apr 30, 2026
Merged

Update to the latest agents#96
Malcolmnixon merged 3 commits into
mainfrom
update-agents

Conversation

@Malcolmnixon
Copy link
Copy Markdown
Member

@Malcolmnixon Malcolmnixon commented Apr 30, 2026

Pull Request

Description

Update to the latest agents and remove the legacy repo-consistency agent

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Closes #

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: pwsh ./lint.ps1 (cross-platform)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Copilot AI review requested due to automatic review settings April 30, 2026 19:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository agent/standards documentation to align with the “latest agents” guidance and removes the legacy repo-consistency specialized agent definition.

Changes:

  • Adds a “Project Overview” section and simplifies specialized-agent reporting guidance in AGENTS.md.
  • Refactors C# standards docs, notably rewriting C# testing guidance toward xUnit v3.
  • Removes the legacy .github/agents/repo-consistency.agent.md file.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
AGENTS.md Adds project overview placeholders and removes the embedded specialized-agent catalog, while keeping delegation/reporting guidance.
.github/standards/csharp-testing.md Rewritten testing standards; now documents xUnit v3 packages, patterns, and examples.
.github/standards/csharp-language.md Simplifies the document by removing redundant headings/sections (globs already define file patterns).
.github/standards/coding-principles.md Tightens documentation expectations (“full symbol documentation”).
.github/agents/repo-consistency.agent.md Deletes the legacy repo-consistency agent definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/standards/csharp-testing.md
Comment thread .github/standards/csharp-testing.md
Comment thread .github/standards/coding-principles.md
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the repository’s C# test framework from MSTest to xUnit v3, updates requirements/standards documentation to match, and removes the legacy repo-consistency agent documentation.

Changes:

  • Switch test project dependencies from MSTest to xUnit v3 and update tests accordingly ([Fact], Assert.Equal, etc.).
  • Update ReqStream OTS requirements include and content from MSTest → xUnit v3.
  • Refresh agent/standards documentation and remove the repo-consistency agent file.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
test/DemaConsulting.TemplateDotNetLibrary.Tests/TemplateDotNetLibraryTests.cs Migrates system tests to xUnit attributes/assertions.
test/DemaConsulting.TemplateDotNetLibrary.Tests/DemoTests.cs Migrates unit tests to xUnit, but loosens exception-type assertions in a couple of places.
test/DemaConsulting.TemplateDotNetLibrary.Tests/DemaConsulting.TemplateDotNetLibrary.Tests.csproj Replaces MSTest packages with xUnit v3 + VS runner and adds global Xunit using.
requirements.yaml Switches ReqStream include from MSTest OTS to xUnit OTS.
docs/reqstream/ots/xunit.yaml Updates OTS requirement text/IDs to reference xUnit v3 packages and linked tests.
AGENTS.md Updates agent documentation structure; introduces template placeholders (TODO).
.github/standards/csharp-testing.md Updates testing standards to xUnit v3; currently overstates “required” packages.
.github/standards/csharp-language.md Streamlines language standards headings/content.
.github/standards/coding-principles.md Updates documentation guidance wording (“Full Symbol Documentation”).
.github/agents/repo-consistency.agent.md Removes legacy agent definition.
.cspell.yaml Updates dictionary term from mstest to xunit.
Comments suppressed due to low confidence (1)

docs/reqstream/ots/xunit.yaml:16

  • The justification states xUnit “writes TRX result files”, but TRX output is produced by dotnet test when configured with the TRX logger (with the VS adapter installed), not by xUnit itself. Consider rewording to reflect that TRX generation comes from the test runner configuration (e.g., --logger trx) so the requirement text is technically accurate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/DemaConsulting.TemplateDotNetLibrary.Tests/DemoTests.cs
Comment thread test/DemaConsulting.TemplateDotNetLibrary.Tests/DemoTests.cs
Comment thread .github/standards/csharp-testing.md
Comment thread AGENTS.md
Comment thread AGENTS.md
Comment thread test/DemaConsulting.TemplateDotNetLibrary.Tests/DemoTests.cs
Comment thread test/DemaConsulting.TemplateDotNetLibrary.Tests/DemoTests.cs
@Malcolmnixon
Copy link
Copy Markdown
Member Author

@copilot The test failed with:
error : xUnit.net v3 test projects must be executable (set project property '<OutputType>Exe</OutputType>'

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

@copilot The test failed with:
error : xUnit.net v3 test projects must be executable (set project property '<OutputType>Exe</OutputType>'

Fixed in cc5d7e2 — added <OutputType>Exe</OutputType> to the test project. All 45 tests pass (15 × net8.0/net9.0/net10.0).

@Malcolmnixon Malcolmnixon merged commit 849d04e into main Apr 30, 2026
6 checks passed
@Malcolmnixon Malcolmnixon deleted the update-agents branch April 30, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants