Update to the latest agents#96
Conversation
There was a problem hiding this comment.
Pull request overview
Updates repository agent/standards documentation to align with the “latest agents” guidance and removes the legacy repo-consistency specialized agent definition.
Changes:
- Adds a “Project Overview” section and simplifies specialized-agent reporting guidance in
AGENTS.md. - Refactors C# standards docs, notably rewriting C# testing guidance toward xUnit v3.
- Removes the legacy
.github/agents/repo-consistency.agent.mdfile.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Adds project overview placeholders and removes the embedded specialized-agent catalog, while keeping delegation/reporting guidance. |
| .github/standards/csharp-testing.md | Rewritten testing standards; now documents xUnit v3 packages, patterns, and examples. |
| .github/standards/csharp-language.md | Simplifies the document by removing redundant headings/sections (globs already define file patterns). |
| .github/standards/coding-principles.md | Tightens documentation expectations (“full symbol documentation”). |
| .github/agents/repo-consistency.agent.md | Deletes the legacy repo-consistency agent definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/demaconsulting/TemplateDotNetLibrary/sessions/2214197c-e295-4c82-ba34-fa9bb4e8a162 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s C# test framework from MSTest to xUnit v3, updates requirements/standards documentation to match, and removes the legacy repo-consistency agent documentation.
Changes:
- Switch test project dependencies from MSTest to xUnit v3 and update tests accordingly (
[Fact],Assert.Equal, etc.). - Update ReqStream OTS requirements include and content from MSTest → xUnit v3.
- Refresh agent/standards documentation and remove the repo-consistency agent file.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/DemaConsulting.TemplateDotNetLibrary.Tests/TemplateDotNetLibraryTests.cs | Migrates system tests to xUnit attributes/assertions. |
| test/DemaConsulting.TemplateDotNetLibrary.Tests/DemoTests.cs | Migrates unit tests to xUnit, but loosens exception-type assertions in a couple of places. |
| test/DemaConsulting.TemplateDotNetLibrary.Tests/DemaConsulting.TemplateDotNetLibrary.Tests.csproj | Replaces MSTest packages with xUnit v3 + VS runner and adds global Xunit using. |
| requirements.yaml | Switches ReqStream include from MSTest OTS to xUnit OTS. |
| docs/reqstream/ots/xunit.yaml | Updates OTS requirement text/IDs to reference xUnit v3 packages and linked tests. |
| AGENTS.md | Updates agent documentation structure; introduces template placeholders (TODO). |
| .github/standards/csharp-testing.md | Updates testing standards to xUnit v3; currently overstates “required” packages. |
| .github/standards/csharp-language.md | Streamlines language standards headings/content. |
| .github/standards/coding-principles.md | Updates documentation guidance wording (“Full Symbol Documentation”). |
| .github/agents/repo-consistency.agent.md | Removes legacy agent definition. |
| .cspell.yaml | Updates dictionary term from mstest to xunit. |
Comments suppressed due to low confidence (1)
docs/reqstream/ots/xunit.yaml:16
- The justification states xUnit “writes TRX result files”, but TRX output is produced by
dotnet testwhen configured with the TRX logger (with the VS adapter installed), not by xUnit itself. Consider rewording to reflect that TRX generation comes from the test runner configuration (e.g.,--logger trx) so the requirement text is technically accurate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot The test failed with: |
Agent-Logs-Url: https://github.com/demaconsulting/TemplateDotNetLibrary/sessions/29326ad6-2a84-4d9b-8a1b-089f268c1d3d Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Pull Request
Description
Update to the latest agents and remove the legacy repo-consistency agent
Type of Change
Related Issues
Closes #
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
pwsh ./lint.ps1(cross-platform)Testing
Documentation
Additional Notes