fix(parser): add explicit lifetime to Cow return type (fixes clippy lint)#89
Merged
Conversation
…e_surrogates Fixes `mismatched_lifetime_syntaxes` lint: `Cow<str>` → `Cow<'_, str>` makes the elided lifetime on the `&str` input and the lifetime in the return type consistent, silencing `-D warnings` under `cargo clippy`. https://claude.ai/code/session_01Fmh1aPCyB1xMDwNQbk56in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cow<str>→Cow<'_, str>insanitize_lone_surrogatesreturn typemismatched_lifetime_syntaxeslint that was failing CI undercargo clippy -- -D warnings&strinput must be consistently expressed in the return typeRoot cause
PR #88 introduced
sanitize_lone_surrogates(s: &str) -> Cow<str>. Rust'smismatched_lifetime_syntaxeslint (enabled via-D warnings) requires that the lifetime hidden in&strand the lifetime inCow<str>be written consistently — either both elided or both explicit. The fix usesCow<'_, str>to make the connection explicit.Generated by Claude Code