feat: complete OracleDocumentStore operations#3179
Open
yugborana wants to merge 4 commits intodeepset-ai:mainfrom
Open
feat: complete OracleDocumentStore operations#3179yugborana wants to merge 4 commits intodeepset-ai:mainfrom
OracleDocumentStore operations#3179yugborana wants to merge 4 commits intodeepset-ai:mainfrom
Conversation
Author
Author
OracleDocumentStore operations
Contributor
|
@yugborana, thanks for your contribution. I will start the review still this week. NOTE: There's no need to tag anyone immediately; once the PR is open, one of us will be assigned to review it. |
Author
|
Thanks for the reply. Sorry for tagging immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…testing
Related Issues
OracleDocumentStoremissing methods and test coverage #3172Proposed Changes:
I finalized the Oracle integration by completing all missing Document Store functions, fixing underlying datatype bugs, and implementing their asynchronous equivalents using asyncio.to_thread to prevent thread-blocking during database calls.
How did you test it?
To ensure total reliability, we rely on 28 unit tests executing entirely in mocked memory to validate parsing logic and component structure, supplemented by 105 real-database integration tests driven by Haystack's strict compliance mixins proving complete systemic alignment. For manual verification, we orchestrated an end-to-end Python script that connects to the live Oracle 23ai Docker container, injects diverse real-world metadata, merges patches, manipulates keyword indexing, and audits the async output states.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:. - yes