Skip to content

feat: complete OracleDocumentStore operations#3179

Open
yugborana wants to merge 4 commits intodeepset-ai:mainfrom
yugborana:feature/oracle-integration-completion
Open

feat: complete OracleDocumentStore operations#3179
yugborana wants to merge 4 commits intodeepset-ai:mainfrom
yugborana:feature/oracle-integration-completion

Conversation

@yugborana
Copy link
Copy Markdown

…testing

Related Issues

Proposed Changes:

I finalized the Oracle integration by completing all missing Document Store functions, fixing underlying datatype bugs, and implementing their asynchronous equivalents using asyncio.to_thread to prevent thread-blocking during database calls.

How did you test it?

To ensure total reliability, we rely on 28 unit tests executing entirely in mocked memory to validate parsing logic and component structure, supplemented by 105 real-database integration tests driven by Haystack's strict compliance mixins proving complete systemic alignment. For manual verification, we orchestrated an end-to-end Python script that connects to the live Oracle 23ai Docker container, injects diverse real-world metadata, merges patches, manipulates keyword indexing, and audits the async output states.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct - yes
  • I have updated the related issue with new insights and changes - yes
  • I added unit tests and updated the docstrings - yes
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:. - yes

@yugborana yugborana requested a review from a team as a code owner April 19, 2026 05:03
@yugborana yugborana requested review from anakin87 and removed request for a team April 19, 2026 05:03
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 19, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Apr 19, 2026
@yugborana
Copy link
Copy Markdown
Author

@yugborana
Copy link
Copy Markdown
Author

@bogdankostic @sjrl

@anakin87 anakin87 requested review from davidsbatista and removed request for anakin87 April 20, 2026 07:26
@davidsbatista davidsbatista changed the title feat: complete OracleDocumentStore methods, hybrid search, and async … feat: complete OracleDocumentStore operations Apr 20, 2026
@davidsbatista
Copy link
Copy Markdown
Contributor

@yugborana, thanks for your contribution. I will start the review still this week.

NOTE: There's no need to tag anyone immediately; once the PR is open, one of us will be assigned to review it.

@yugborana
Copy link
Copy Markdown
Author

Thanks for the reply. Sorry for tagging immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OracleDocumentStore missing methods and test coverage

3 participants