build(pyproject): adopt PEP 639 license metadata#2433
build(pyproject): adopt PEP 639 license metadata#2433njzjz-bot wants to merge 1 commit intodeepmodeling:masterfrom
Conversation
Use SPDX license expression. Remove deprecated license classifier. Authored by OpenClaw (model: gpt-5.4)
Merging this PR will not alter performance
|
📝 WalkthroughWalkthroughThe project's license declaration in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 19: pyproject.toml was changed to license = "LGPL-3.0-or-later" but the
conda recipe still declares "LGPL-3.0-only", causing inconsistent published
metadata; update the conda recipe's license declaration (the license field in
meta.yaml that currently reads "LGPL-3.0-only") to the matching SPDX expression
"LGPL-3.0-or-later" and ensure any related license metadata (e.g.,
license_family or license_file references) reflect the same "or-later" intent so
both pyproject.toml and the conda/meta.yaml are aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| {name = "Jinzhe Zeng", email = "jinzhe.zeng@ustc.edu.cn"}, | ||
| ] | ||
| license = {file = "LICENSE"} | ||
| license = "LGPL-3.0-or-later" |
There was a problem hiding this comment.
Sync conda license metadata with the new SPDX expression.
Good update on Line 19, but this creates inconsistent published license metadata: pyproject.toml now says LGPL-3.0-or-later while conda/recipe/meta.yaml:57-59 still declares LGPL-3.0-only. Please align them to avoid compliance ambiguity across package channels.
Proposed follow-up diff (outside this file)
--- a/conda/recipe/meta.yaml
+++ b/conda/recipe/meta.yaml
@@
-license: LGPL-3.0-only
+license: LGPL-3.0-or-later
license_family: LGPL
license_file: LICENSE🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pyproject.toml` at line 19, pyproject.toml was changed to license =
"LGPL-3.0-or-later" but the conda recipe still declares "LGPL-3.0-only", causing
inconsistent published metadata; update the conda recipe's license declaration
(the license field in meta.yaml that currently reads "LGPL-3.0-only") to the
matching SPDX expression "LGPL-3.0-or-later" and ensure any related license
metadata (e.g., license_family or license_file references) reflect the same
"or-later" intent so both pyproject.toml and the conda/meta.yaml are aligned.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2433 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 17 17
Lines 1532 1532
=======================================
Hits 1459 1459
Misses 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use SPDX license expression:
LGPL-3.0-or-laterAuthored by OpenClaw (model: gpt-5.4)
Summary by CodeRabbit