Skip to content

build(pyproject): adopt PEP 639 license metadata#2433

Open
njzjz-bot wants to merge 1 commit intodeepmodeling:masterfrom
njzjz-bothub:openclaw/pep639-license
Open

build(pyproject): adopt PEP 639 license metadata#2433
njzjz-bot wants to merge 1 commit intodeepmodeling:masterfrom
njzjz-bothub:openclaw/pep639-license

Conversation

@njzjz-bot
Copy link
Copy Markdown
Collaborator

@njzjz-bot njzjz-bot commented Apr 6, 2026

Use SPDX license expression: LGPL-3.0-or-later

Authored by OpenClaw (model: gpt-5.4)

Summary by CodeRabbit

  • Chores
    • Updated project license metadata configuration to use SPDX standard identifier format.

Use SPDX license expression.
Remove deprecated license classifier.

Authored by OpenClaw (model: gpt-5.4)
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 6, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 9 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing njzjz-bothub:openclaw/pep639-license (eb9cee6) with master (1eda938)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

📝 Walkthrough

Walkthrough

The project's license declaration in pyproject.toml was updated to use the SPDX identifier format (LGPL-3.0-or-later) instead of referencing a local LICENSE file, with a corresponding removal of the LGPLv3 Trove classifier.

Changes

Cohort / File(s) Summary
License Configuration
pyproject.toml
Changed license field from file reference to SPDX identifier LGPL-3.0-or-later; removed redundant LGPLv3 Trove classifier.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adopting PEP 639 license metadata by updating the license field from a file reference to an SPDX identifier.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pyproject.toml`:
- Line 19: pyproject.toml was changed to license = "LGPL-3.0-or-later" but the
conda recipe still declares "LGPL-3.0-only", causing inconsistent published
metadata; update the conda recipe's license declaration (the license field in
meta.yaml that currently reads "LGPL-3.0-only") to the matching SPDX expression
"LGPL-3.0-or-later" and ensure any related license metadata (e.g.,
license_family or license_file references) reflect the same "or-later" intent so
both pyproject.toml and the conda/meta.yaml are aligned.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c7cf9672-39c4-4347-90f8-696de2b62f7a

📥 Commits

Reviewing files that changed from the base of the PR and between 1eda938 and eb9cee6.

📒 Files selected for processing (1)
  • pyproject.toml

Comment thread pyproject.toml
{name = "Jinzhe Zeng", email = "jinzhe.zeng@ustc.edu.cn"},
]
license = {file = "LICENSE"}
license = "LGPL-3.0-or-later"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Sync conda license metadata with the new SPDX expression.

Good update on Line 19, but this creates inconsistent published license metadata: pyproject.toml now says LGPL-3.0-or-later while conda/recipe/meta.yaml:57-59 still declares LGPL-3.0-only. Please align them to avoid compliance ambiguity across package channels.

Proposed follow-up diff (outside this file)
--- a/conda/recipe/meta.yaml
+++ b/conda/recipe/meta.yaml
@@
-license: LGPL-3.0-only
+license: LGPL-3.0-or-later
   license_family: LGPL
   license_file: LICENSE
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@pyproject.toml` at line 19, pyproject.toml was changed to license =
"LGPL-3.0-or-later" but the conda recipe still declares "LGPL-3.0-only", causing
inconsistent published metadata; update the conda recipe's license declaration
(the license field in meta.yaml that currently reads "LGPL-3.0-only") to the
matching SPDX expression "LGPL-3.0-or-later" and ensure any related license
metadata (e.g., license_family or license_file references) reflect the same
"or-later" intent so both pyproject.toml and the conda/meta.yaml are aligned.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.23%. Comparing base (1eda938) to head (eb9cee6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2433   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files          17       17           
  Lines        1532     1532           
=======================================
  Hits         1459     1459           
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant