Skip to content

[linux-6.6.y] ACPI: APEI: GHES: Add ghes_edac support for __ZX__ and _BYO_ systems#1693

Merged
opsiff merged 1 commit into
deepin-community:linux-6.6.yfrom
leoliu-oc:linux-6.6.y-136-gtes_edac
May 13, 2026
Merged

[linux-6.6.y] ACPI: APEI: GHES: Add ghes_edac support for __ZX__ and _BYO_ systems#1693
opsiff merged 1 commit into
deepin-community:linux-6.6.yfrom
leoliu-oc:linux-6.6.y-136-gtes_edac

Conversation

@leoliu-oc
Copy link
Copy Markdown
Contributor

@leoliu-oc leoliu-oc commented May 12, 2026

Let ghes_edac be the preferred driver to load on ZX and BYO systems by extending the platform detection list in ghes.c

Tested-by: Lyle Li LyleLi@zhaoxin.com
Acked-by: Borislav Petkov (AMD) bp@alien8.de
[ rjw: Subject and changelog edits ]
Link: https://patch.msgid.link/20260128025216.12564-1-TonyWWang-oc@zhaoxin.com

Summary by Sourcery

New Features:

  • Treat ZX EDK2 and BYO BYOSOFT systems as platforms where ghes_edac is the preferred EDAC driver.

Let ghes_edac be the preferred driver to load on  __ZX__ and _BYO_
systems by extending the platform detection list in ghes.c

Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
Tested-by: Lyle Li <LyleLi@zhaoxin.com>
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
[ rjw: Subject and changelog edits ]
Link: https://patch.msgid.link/20260128025216.12564-1-TonyWWang-oc@zhaoxin.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: LeoLiu-oc <leoliu-oc@zhaoxin.com>
@deepin-ci-robot deepin-ci-robot requested review from Wenlp and shy129 May 12, 2026 13:34
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extends ACPI APEI GHES platform detection so that ghes_edac becomes the preferred EDAC driver on ZX and BYO systems by adding their FADT signatures to the supported platform list.

File-Level Changes

Change Details Files
Extend GHES platform detection to treat ZX and BYO systems as platforms where ghes_edac is preferred.
  • Update the acpi_platform_list array in acpi_ghes_init to include an entry for ZX systems using EDK2 with FADT revision >= 3 and ACPI_SIG_FADT matching
  • Add a second acpi_platform_list entry for BYO systems from BYOSOFT with FADT revision >= 3 and ACPI_SIG_FADT matching
drivers/acpi/apei/ghes.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

Hi @leoliu-oc. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the x86 platform allowlist used by ghes_get_devices() so that ghes_edac is treated as the preferred EDAC driver on additional ACPI firmware/platform combinations (Zhaoxin EDK2 and BYOSOFT).

Changes:

  • Add ACPI platform list entries matching FADT OEMID/OEM Table ID for __ZX__/EDK2 and _BYO_/BYOSOFT.
  • Require FADT OEM revision >= 3 for those new platform matches via greater_than_or_equal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opsiff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff opsiff merged commit 5b73948 into deepin-community:linux-6.6.y May 13, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants