Skip to content

fix(telemetry): explicitly start session after init #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukeocodes merged 1 commit into from
May 9, 2026
+16 −2
Merged

fix(telemetry): explicitly start session after init #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/deepctl-telemetry/src/deepctl_telemetry/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ def init_telemetry(config: Config) -> bool:
)
sentry_sdk.set_tag("cli.version", cli_version)

sentry_sdk.start_session()
atexit.register(_flush_on_exit)

_initialized = True
Expand Down
17 changes: 15 additions & 2 deletions packages/deepctl-telemetry/tests/unit/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,25 +53,38 @@ def reset_initialized(self) -> None:
def test_init_enables_auto_session_tracking(self) -> None:
with patch("deepctl_telemetry.client.atexit.register"), patch(
"sentry_sdk.init"
) as mock_init, patch("sentry_sdk.set_tag"):
) as mock_init, patch("sentry_sdk.set_tag"), patch(
"sentry_sdk.start_session"
):
init_telemetry(_config(True))

assert mock_init.called
kwargs = mock_init.call_args.kwargs
assert kwargs["auto_session_tracking"] is True
assert kwargs["traces_sample_rate"] == 0.0
assert kwargs["profiles_sample_rate"] == 0.0
assert "session_mode" not in kwargs

def test_init_registers_atexit_flush(self) -> None:
from deepctl_telemetry.client import _flush_on_exit

with patch(
"deepctl_telemetry.client.atexit.register"
) as mock_register, patch("sentry_sdk.init"), patch("sentry_sdk.set_tag"):
) as mock_register, patch("sentry_sdk.init"), patch(
"sentry_sdk.set_tag"
), patch("sentry_sdk.start_session"):
init_telemetry(_config(True))

mock_register.assert_called_once_with(_flush_on_exit)

def test_init_starts_session(self) -> None:
with patch("sentry_sdk.init"), patch("sentry_sdk.set_tag"), patch(
"deepctl_telemetry.client.atexit.register"
), patch("sentry_sdk.start_session") as mock_start:
init_telemetry(_config(True))

mock_start.assert_called_once_with()

def test_disabled_does_not_register_atexit(self) -> None:
with patch(
"deepctl_telemetry.client.atexit.register"
Expand Down
Loading