process.env is undefined#723
Open
aylanbrown wants to merge 3 commits intodebug-js:masterfrom
aylanbrown:master
Open
process.env is undefined#723aylanbrown wants to merge 3 commits intodebug-js:masterfrom aylanbrown:master
aylanbrown wants to merge 3 commits intodebug-js:masterfrom
aylanbrown:master
Conversation
Qix-
requested changes
Sep 3, 2019
src/browser.js
Outdated
| // If debug isn't set in LS, and we're in Electron, try to load $DEBUG | ||
| if (!r && typeof process !== 'undefined' && 'env' in process) { | ||
| // process.env is undefined in sometimes, and it will throw a exception | ||
| if (!r && typeof process !== 'undefined' && 'env' in process && process.env !== undefined) { |
Member
There was a problem hiding this comment.
The second two checks can be simplified as just process.env.
Member
|
Can you squash please? :) |
Author
I built my project by webpack, and browser throw 'production is not undefined'. Check only |
Member
|
Huh? I mean squash your commits with git. |
|
@Qix-, github allows to squash commits and merge them: |
Member
|
@xamgore I'm very aware. I was not near a computer at the time and the mobile client does not have the feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.