Factor out UUID functions into common module#400
Open
gabotechs wants to merge 2 commits intogabrielmusat/async-distributed-planningfrom
Open
Factor out UUID functions into common module#400gabotechs wants to merge 2 commits intogabrielmusat/async-distributed-planningfrom
gabotechs wants to merge 2 commits intogabrielmusat/async-distributed-planningfrom
Conversation
gabotechs
changed the base branch from
main
to
gabrielmusat/async-distributed-planning
gabotechs
force-pushed
the
gabrielmusat/async-distributed-planning
branch
2 times, most recently
from
67d13ae to
6514d92
Compare
gabotechs
force-pushed
the
gabrielmusat/refactor-uuid-functions
branch
from
7dfdad4 to
2924279
Compare
gabotechs
force-pushed
the
gabrielmusat/async-distributed-planning
branch
from
6514d92 to
6568a37
Compare
gabotechs
force-pushed
the
gabrielmusat/refactor-uuid-functions
branch
from
2924279 to
52615f9
Compare
gabotechs
force-pushed
the
gabrielmusat/async-distributed-planning
branch
from
6568a37 to
dd314a3
Compare
gabotechs
force-pushed
the
gabrielmusat/refactor-uuid-functions
branch
from
52615f9 to
87a1c4d
Compare
gabotechs
force-pushed
the
gabrielmusat/async-distributed-planning
branch
from
dd314a3 to
797ee5d
Compare
gabotechs
force-pushed
the
gabrielmusat/refactor-uuid-functions
branch
from
87a1c4d to
709e6de
Compare
jayshrivastava
approved these changes
Apr 16, 2026
Collaborator
jayshrivastava
left a comment
jayshrivastava
left a comment
There was a problem hiding this comment.
LGTM but you're missing one call to serialize_uuid here:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some preparatory refactor for keeping future PRs clean:
This refactor, even if small, is not really related to that PR, so I factored it out.