Skip to content

Fix false duplicate source code path error for git-sourced apps#4996

Open
denik wants to merge 6 commits intomainfrom
denik/random-bugfixes-2
Open

Fix false duplicate source code path error for git-sourced apps#4996
denik wants to merge 6 commits intomainfrom
denik/random-bugfixes-2

Conversation

@denik
Copy link
Copy Markdown
Contributor

@denik denik commented Apr 16, 2026

Changes

  • Fix false "Duplicate app source code path" error when multiple apps use git_source instead of source_code_path. The duplicate check keyed on SourceCodePath, so all git-sourced apps collided on the empty string. Now skips the check when SourceCodePath is empty.

Why

Users with multiple git-sourced apps in a bundle get a spurious validation error that blocks bundle validate and bundle deploy.

Tests

  • Acceptance test with two git-sourced apps verifies validation passes without false duplicate error.
  • Confirmed the test fails on v0.296.0 (latest release) as a regression check.

Output of go test ./acceptance -run TestAccept/bundle/apps/git_source_no_duplicate -useversion 0.296.0:

[CLI] bundle validate
Error: Duplicate app source code path

app resource 'app1' has the same source code path as app resource 'app2', this will lead to the app configuration being overriden by each other

denik added 6 commits April 16, 2026 14:17
When multiple apps use git_source instead of source_code_path, the
duplicate path check incorrectly flags them because all git-sourced
apps have an empty SourceCodePath, colliding on the same map key "".

Skip the duplicate check when SourceCodePath is empty.

Task: 001.md

Co-authored-by: Isaac
Include the output of running the acceptance test against v0.296.0
(`-useversion 0.296.0`), confirming the test catches a real regression:
the old CLI falsely reports "Duplicate app source code path" for
git-sourced apps that have no source_code_path set.

Task: 003.md

Co-authored-by: Isaac
@github-actions
Copy link
Copy Markdown

Approval status: pending

/acceptance/bundle/ - needs approval

Files: acceptance/bundle/apps/git_source_no_duplicate/databricks.yml, acceptance/bundle/apps/git_source_no_duplicate/out.test.toml, acceptance/bundle/apps/git_source_no_duplicate/output.txt, acceptance/bundle/apps/git_source_no_duplicate/script, acceptance/bundle/apps/git_source_no_duplicate/test.toml
Suggested: @andrewnester
Also eligible: @pietern, @lennartkats-db, @shreyas-goenka, @anton-107, @janniklasrose

/bundle/ - needs approval

Files: bundle/apps/validate.go
Suggested: @andrewnester
Also eligible: @pietern, @lennartkats-db, @shreyas-goenka, @anton-107, @janniklasrose

General files (require maintainer)

Files: NEXT_CHANGELOG.md
Based on git history:

  • @andrewnester -- recent work in ./, bundle/apps/

Any maintainer (@andrewnester, @anton-107, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant