Open
Conversation
Merge two separate if-blocks for compute-id and cluster-id flags into one since both bind to the same variable. Remove unnecessary outer conditional in plan.go that guarded InitFunc (deploy.go already sets it unconditionally). Task: 001.md Co-authored-by: Isaac
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--compute-id/--cluster-idflag checks into a single condition indeploy.goandplan.go, since both flags bind to the same variable.InitFuncassignment inplan.gounconditional, matchingdeploy.go.Why
Both flags write to the same
clusterIdvariable, so checking them separately is redundant. Aligningplan.gowithdeploy.goreduces the chance of future divergence.Tests
No new tests — behavior-preserving refactor.