Skip terraform variant for Lakebase acceptance tests with TF provider bugs#4750
Closed
shreyas-goenka wants to merge 1 commit intomainfrom
Closed
Skip terraform variant for Lakebase acceptance tests with TF provider bugs#4750shreyas-goenka wants to merge 1 commit intomainfrom
shreyas-goenka wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 6ac73c0
21 interesting tests: 9 SKIP, 6 flaky, 6 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables the terraform variant for two Lakebase acceptance tests that fail due to bugs in the Terraform provider (v1.111.0). The direct variant continues to pass and run.
Tests disabled for terraform:
postgres_endpoints/basic— TF provider endpoint delete fails with 409 "reconciliation in progress" (databricks/terraform-provider-databricks#5482)postgres_projects/update_display_name— TF provider project update fails with "Unknown field path in update_mask: 'initial_endpoint_spec'" (databricks/terraform-provider-databricks#5481)Why direct works but terraform doesn't:
InitialEndpointSpec: nilin the update request and computes the update mask dynamically from only the changedspec.*fields. The TF provider's auto-generated code hardcodes"initial_endpoint_spec,spec"in the update mask, which the backend rejects.DoDeletethat catches HTTP 409 errors containing "reconciliation" and retries with 2-second intervals for up to 2 minutes. The TF provider's auto-generatedDeletemethod has no retry logic and fails immediately on 409.Both issues are in auto-generated code in the TF provider that needs to be fixed in the codegen framework.
Test plan
This pull request was AI-assisted by Isaac.