Fix mask_amount_rounded type mismatch and add missing PII maskers to financial services#22
Open
puichinglee wants to merge 1 commit into
Open
Fix mask_amount_rounded type mismatch and add missing PII maskers to financial services#22puichinglee wants to merge 1 commit into
puichinglee wants to merge 1 commit into
Conversation
… PII maskers - Rename mask_amount_round → mask_amount_rounded (canonical name in function_registry.json) - Fix return type from RETURNS STRING to RETURNS DECIMAL(18,2) and remove $ prefix that broke DECIMAL/DOUBLE columns at runtime - Add mask_email, mask_phone, mask_address functions (ported from retail.yaml) so the LLM has matching functions for tagged PII columns - Add Phone Number and Customer Address identifiers - Update prompt_overlay to reflect all changes Co-authored-by: Isaac
Contributor
Author
Test Results: Unit TestsCoverage
Key validations for this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mask_amount_roundedruntime breakage:mask_amount_roundreturnedSTRINGwith a$prefix (CONCAT('$', CAST(ROUND(...)))) but the underlying columns areDECIMAL/DOUBLE, causing type errors at query time. Renamed tomask_amount_roundedto match the canonical name infunction_registry.jsonand changed the return type toRETURNS DECIMAL(18,2)with a cleanROUND(amount, -3)body.Customer Emailcolumns and routes them tomask_email, but the function definition didn't exist infinancial_services.yaml. Addedmask_email,mask_phone, andmask_address(ported fromretail.yaml) plusPhone NumberandCustomer Addressidentifiers so all tagged PII columns have matching functions.