Fix index increment in Signature validation#73
Merged
aeberhart merged 2 commits intodashjoin:mainfrom Oct 24, 2025
Merged
Conversation
Due to the fixed index (index = 0), always the first capturing group is selected. This was creating a problem when the signature had different types parameters.
Contributor
|
Dear @Advaitva, thanks for the fix. Could you please provide a unit test that shows the problem? |
Contributor
Author
|
Hi @aeberhart, please have a look at the unit test in my commit. Here are the screenshots proving the same - |
Contributor
|
checked against the original implementation: we translate to but forgot to inc the counter. The fix changed the behaviour of com.dashjoin.jsonata.SignatureTest.testParametersAreConvertedToArrays() the failing unit test was fixed in a subsequent commit. Thanks @Advaitva ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Due to the fixed index (index = 0), always the first capturing group is selected. This was creating a problem when the signature had different types parameters.