Skip to content

GuardsSelection Extend: Unit will guard ally when cannot attack target under cursor, without rushing to enemy's face#3

Open
dnqbob wants to merge 4 commits intodarkademic:devfrom
dnqbob:guardselection
Open

GuardsSelection Extend: Unit will guard ally when cannot attack target under cursor, without rushing to enemy's face#3
dnqbob wants to merge 4 commits intodarkademic:devfrom
dnqbob:guardselection

Conversation

@dnqbob
Copy link

@dnqbob dnqbob commented Jan 15, 2024

Life improvement
Image Update:
improve

@darkademic darkademic force-pushed the dev branch 5 times, most recently from 8063278 to 68b161a Compare January 15, 2024 22:13
@dnqbob
Copy link
Author

dnqbob commented Jan 16, 2024

The second commit: allow closest ally to be guarded when ally closest to target is too far away
examp

@darkademic darkademic force-pushed the dev branch 6 times, most recently from e12b04d to 25c5706 Compare February 10, 2024 11:29
@dnqbob dnqbob changed the title GuardsSelection Extend: Support unit will guard ally when cannot attack target under cursor GuardsSelection Extend: Unit will guard ally when cannot attack target under cursor Feb 13, 2024
@dnqbob dnqbob changed the title GuardsSelection Extend: Unit will guard ally when cannot attack target under cursor GuardsSelection Extend: Unit will guard ally when cannot attack target under cursor, without rushing to enemy's face Feb 13, 2024
@darkademic
Copy link
Owner

Hmm does this do something similar to our KeepsDistance trait? That will basically make the unit stay away from units it can't attack, when an attack order is given to other units in the same selection.

@dnqbob
Copy link
Author

dnqbob commented Feb 14, 2024

I didn't notice KeepsDistance here, feels very useful and simple as well.

@dnqbob
Copy link
Author

dnqbob commented Feb 14, 2024

Maybe a small benefit can bring in this PR compared to KeepsDistance is, when ordered to attack unattackable, healer unit will not stop healing and try move within range.

@dnqbob
Copy link
Author

dnqbob commented Feb 14, 2024

Actually, I think we can merge the function of KeepsDistance into GuardsSelection here: when there is nothing can be guarded at AttackGuard order, actor will move within range instead of doing nothing.

@dnqbob dnqbob marked this pull request as draft February 14, 2024 04:15
@dnqbob dnqbob marked this pull request as ready for review February 14, 2024 04:40
@dnqbob dnqbob force-pushed the guardselection branch 2 times, most recently from f2cbe4c to 4790871 Compare February 16, 2024 09:37
@darkademic darkademic force-pushed the dev branch 2 times, most recently from 9ab1e9f to e0ae6ff Compare February 17, 2024 20:54
@darkademic darkademic force-pushed the dev branch 2 times, most recently from 1bb5cda to e4c8f1a Compare March 30, 2024 07:30
@darkademic darkademic force-pushed the dev branch 3 times, most recently from 79b9458 to 1527be6 Compare April 28, 2024 14:57
@darkademic darkademic force-pushed the dev branch 4 times, most recently from 4b9aa66 to 2c93d56 Compare May 24, 2024 16:25
@darkademic darkademic force-pushed the dev branch 5 times, most recently from 394a043 to 2589bcc Compare June 5, 2024 19:51
@darkademic darkademic force-pushed the dev branch 3 times, most recently from c72c801 to a46a031 Compare June 23, 2024 08:47
@darkademic darkademic force-pushed the dev branch 5 times, most recently from 7088645 to 6afdff5 Compare June 30, 2024 10:22
@darkademic darkademic force-pushed the dev branch 2 times, most recently from a74d3c3 to 61c6b3c Compare August 2, 2024 19:48
@darkademic darkademic force-pushed the dev branch 3 times, most recently from 46a9a9e to 58ddacd Compare October 12, 2024 20:24
@darkademic darkademic force-pushed the dev branch 2 times, most recently from c52093a to 3a309b6 Compare October 24, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants