-
Notifications
You must be signed in to change notification settings - Fork 139
Add crewai workflow extension #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: yaron2 <schneider.yaron@live.com>
Signed-off-by: yaron2 <schneider.yaron@live.com>
Signed-off-by: yaron2 <schneider.yaron@live.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 86.63% 86.73% +0.10%
==========================================
Files 84 103 +19
Lines 4473 7133 +2660
==========================================
+ Hits 3875 6187 +2312
- Misses 598 946 +348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| # Retry policy for activities | ||
| retry_policy = RetryPolicy( | ||
| max_number_of_attempts=3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be changed to run forever by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will complete my review tomorrow - few comments so far for ya!
| [metadata] | ||
| url = https://dapr.io/ | ||
| author = Dapr Authors | ||
| author_email = daprweb@microsoft.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this right..?
| # -*- coding: utf-8 -*- | ||
|
|
||
| """ | ||
| Copyright 2025 The Dapr Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Copyright 2025 The Dapr Authors | |
| Copyright 2026 The Dapr Authors |
pls double check this applies to all copyright docstrings
This PR is the first of 4 to add first class workflow support to 3rd party agent frameworks. This PR adds the extension, unit tests and examples for both a simple agent and a script to test recovery in case of a failure.