Skip to content

enabled and fixed modernize-pass-by-value clang-tidy warnings / avoid some unnecessary copies#529

Draft
firewave wants to merge 3 commits intodanmar:masterfrom
firewave:tidy-passby
Draft

enabled and fixed modernize-pass-by-value clang-tidy warnings / avoid some unnecessary copies#529
firewave wants to merge 3 commits intodanmar:masterfrom
firewave:tidy-passby

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Sep 1, 2025

No description provided.

@firewave firewave marked this pull request as draft September 1, 2025 06:43
@firewave
Copy link
Collaborator Author

firewave commented Sep 1, 2025

callgrind in CI

g++ - 74,990,727 -> 76,190,727
clang++ - 70,436,671 -> 71,500,835

@firewave
Copy link
Collaborator Author

firewave commented Sep 1, 2025

Trying to mitigate the regression makes things worse although I am able to reduce the amount of std::string copies. There is still memcpy() calls I do not even understand where they are coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant