Implement #14290: GUI: detailed progress view that shows what files the threads are working on#8167
Implement #14290: GUI: detailed progress view that shows what files the threads are working on#8167ludviggunne wants to merge 8 commits intodanmar:mainfrom
Conversation
ludviggunne
force-pushed
the
14290
branch
3 times, most recently
from
f2aed22 to
775af90
Compare
|
ludviggunne
force-pushed
the
14290
branch
2 times, most recently
from
076e2a0 to
d02ffb7
Compare
|
| selfcheck_options="-q -j$(nproc) --std=c++11 --template=selfcheck --showtime=file-total -D__GNUC__ --error-exitcode=1 --inline-suppr --suppressions-list=.selfcheck_suppressions --library=gnu --inconclusive --enable=style,performance,portability,warning,missingInclude,information --exception-handling --debug-warnings --check-level=exhaustive" | ||
| cppcheck_options="-D__CPPCHECK__ -DCHECK_INTERNAL -DHAVE_RULES --library=cppcheck-lib -Ilib -Iexternals/simplecpp/ -Iexternals/tinyxml2" | ||
| gui_options="-DQT_VERSION=0x060000 -DQ_MOC_OUTPUT_REVISION=68 -DQT_CHARTS_LIB -DQT_MOC_HAS_STRINGDATA --library=qt" | ||
| gui_options="$gui_options --suppress=functionStatic:cmake.output/gui/ui_threaddetails.h:44" |
There was a problem hiding this comment.
basically I feel that we can suppress all functionStatic all ui_*.h files it does not feel interesting to see those warnings in these files.
In .selfcheck_suppressions we have this already:
functionStatic:*/ui_fileview.h
so I suggest that you tweak .selfcheck_suppressions..
| const std::string& fname = file->spath(); | ||
| qDebug() << "Checking file" << QString::fromStdString(fname); | ||
|
|
||
| const Details details = { mThreadIndex, fname, QTime::currentTime(), }; |
There was a problem hiding this comment.
I don't like the =. It makes it more explicit that no assignment operator is executed if you remove that imho.
|
|
||
| public: | ||
| struct Details { | ||
| int index; |
| public: | ||
| struct Details { | ||
| int index; | ||
| std::string file; |
There was a problem hiding this comment.
I think in Qt code you typically prefer to switch to QString unless you have reasons to stick with std::string.
|
|
||
| void stop(); | ||
|
|
||
| void setThreadIndex(int index); |
There was a problem hiding this comment.
I am not sure why the thread index isn't passed to the CheckThread constructor instead. it could then be a const member.
|
|
||
| ThreadDetails::~ThreadDetails() | ||
| { | ||
| delete mUi; |
There was a problem hiding this comment.
I have the feeling that this destructor is never called. The window is not destroyed just because it is closed.
|
|
||
| void MainWindow::showThreadDetails() | ||
| { | ||
| auto *td = new ThreadDetails; |
There was a problem hiding this comment.
With this code, you can create several ThreadDetails windows.
There was a problem hiding this comment.
Problem:
- I create a ThreadDetails window
- I close MainWindow
- The main windows is closed but the thread details window keeps running.
2 participants
No description provided.