Skip to content

#73 - support NaN and Infinity parsing in python tokenizer#76

Open
daggaz wants to merge 2 commits intomasterfrom
feature/73
Open

#73 - support NaN and Infinity parsing in python tokenizer#76
daggaz wants to merge 2 commits intomasterfrom
feature/73

Conversation

@daggaz
Copy link
Copy Markdown
Owner

@daggaz daggaz commented Apr 3, 2026

This PR adds NaN and Infinity processing in response to #73

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 97.53086% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.52%. Comparing base (974f8e6) to head (7844c2d).

Files with missing lines Patch % Lines
src/json_stream/tokenizer.py 96.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   96.41%   96.52%   +0.11%     
==========================================
  Files          29       29              
  Lines        1562     1642      +80     
==========================================
+ Hits         1506     1585      +79     
- Misses         56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@smheidrich smheidrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes seem fine to me and I've duplicated them for the Rust tokenizer in smheidrich/py-json-stream-rs-tokenizer#150.

But the PR title and commit message reference issue #72 which should be changed to #73.

@daggaz daggaz changed the title #72 - support NaN and Infinity parsing in python tokenizer #73 - support NaN and Infinity parsing in python tokenizer Apr 6, 2026
@daggaz
Copy link
Copy Markdown
Owner Author

daggaz commented Apr 6, 2026

The code changes seem fine to me and I've duplicated them for the Rust tokenizer in smheidrich/py-json-stream-rs-tokenizer#150.

But the PR title and commit message reference issue #72 which should be changed to #73.

Whoops! Fixed.

Copy link
Copy Markdown
Contributor

@smheidrich smheidrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge smheidrich/py-json-stream-rs-tokenizer#150 now & get started publishing a new version of the Rust tokenizer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants