Add barWidth/barDepth params to Graph3DBars; document alpha#1873
Merged
mscuthbert merged 2 commits intomasterfrom Apr 20, 2026
Merged
Add barWidth/barDepth params to Graph3DBars; document alpha#1873mscuthbert merged 2 commits intomasterfrom
mscuthbert merged 2 commits intomasterfrom
Conversation
Adds explicit `barWidth` and `barDepth` keyword arguments to `Graph3DBars.__init__` so callers can set fixed bar dimensions without needing per-point format dicts. When `None` (default) the existing automatic formulas are used. Also documents the previously undocumented `alpha` parameter and refactors `renderSubplot` to avoid redundant multi-pass iteration. AI-assisted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
coverage: 93.071% (-0.003%) from 93.074% — graph3d-configuration into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
barWidthandbarDepthkeyword arguments toGraph3DBars.__init__so callers can set fixed bar dimensions without using per-point format dicts.alpha,barWidth, andbarDepthparameters in the class docstringThis PR is needed to be able to recreate graphs that look like the old music21 2010 paper's graphs.