feat: declaritive config selector#43
Draft
mleonidas wants to merge 1 commit intoctrlplanedev:mainfrom
Draft
Conversation
* starting implementation that needs work for deleting resources that aren't in the config but match the selector ctrlplanedev#39
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jsbroks
reviewed
Jan 22, 2026
Comment on lines
+226
to
+233
| } | ||
| results = append(results, result) | ||
| } else { | ||
| result, err := doc.Apply(docCtx) | ||
| if err != nil { | ||
| log.Error("Failed to apply document", "error", err) | ||
| } | ||
| results = append(results, result) |
Member
There was a problem hiding this comment.
Minor note: for future PRs, we should prefer early returns where possible. In most cases, the else isn’t needed.
Contributor
Author
|
depends on add delete endpoint for resources |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply: Add--selectorflag for declarative resource management (including deletions) #39This is still a work in progress. There are several optimizations to be made, and I believe there are some issues with the config resources that need to be ironed out. There’s also some memory escaping to the heap due to not pre-allocating known sizes, which will be addressed before a full review