feature: vendor Csound codemirror support and add Markdown features#491
Draft
Nandos0804 wants to merge 11 commits into
Draft
feature: vendor Csound codemirror support and add Markdown features#491Nandos0804 wants to merge 11 commits into
Nandos0804 wants to merge 11 commits into
Conversation
…port Fork @hlolli/codemirror-lang-csound into plugins/codemirror-lang-csound. Grammar additions: - multi-assignment: iAtt, iDec = 0.1, 0.4 - for/in/do/od loop syntax - switch/case/default:/endswitch syntax - improved <CsOptions> parsing Updated highlighter styleTags for all new keywords. Migrated deprecated @codemirror/text import to @codemirror/state.
Install @codemirror/lang-markdown. Detect .md/.markdown filenames and switch the language extension to markdown() with syntaxHighlighting(defaultHighlightStyle) instead of csoundMode().
Add 'md' category to MediaFileCategory, detect .md/.markdown in getFileTypeIconDetails, extend fileIcons type, and add per-theme amber/golden badge colours for all six themes.
Rename @hlolli/codemirror-lang-csound -> @csound/codemirror-lang-csound in package.json, workspace build script, global.d.ts, editor import, and README references. Also update CodeMirror/Lezer packages to latest and add @codemirror/lang-markdown dependency.
Contributor
Author
|
Addresses #34 and moves codemirror as a vendor folder. Current used version:
|
Nandos0804
changed the title
Member
|
Might want to try:
https://github.com/kunstmusik/codemirror-lang-csound
It has fair amount of CS7 language support already.
…On Mon, May 25, 2026 at 3:55 PM Giuseppe Ernandez ***@***.***> wrote:
*Nandos0804* left a comment (csound/web-ide#491)
<#491 (comment)>
Addresses #34 <#34> and moves
codemirror as a vendor folder. Current used version:
Package Before Now
codemirror 6.0.1 6.0.2
@codemirror/state 6.5.0 6.6.0
@codemirror/view 6.35.3 6.43.0
@codemirror/language 6.10.6 6.12.3
@codemirror/autocomplete 6.18.3 6.20.2
@codemirror/commands 6.7.1 6.10.3
@codemirror/lint 6.8.4 6.9.6
@codemirror/search 6.5.8 6.7.0
@lezer/common 1.2.3 1.5.2
@lezer/lr 1.4.2 1.4.10
@lezer/highlight 1.2.1 1.2.3
—
Reply to this email directly, view it on GitHub
<#491?email_source=notifications&email_token=AAMMA64JOTJZFEMN3VFWZGT44SQJXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJTGY4DIOJXGIZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-4536849722>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMMA673GLXGGO2IPQRJYEL44SQJXAVCNFSM6AAAAACZMUWPMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMZWHA2DSNZSGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Member
|
bad me here, I should have remembered that you did codemirror. Somehow I had stored it in my brain incorrectly (and made the suggestion to vendor my ancient work). Yeh no need to re-invent the wheel, if we can use or vendor your previous work. I only say vendor if we need custom features. Which I forgot if I added to my older fork. |
Member
|
Happy to update this library for new features, I'm using it in the new Blue as well. It's published on NPM btw. |
Contributor
Author
|
If I can share my view: if we all agree, I’m in favor of avoiding scattered code and maintaining different forks for the same feature set or implementation. I’m also fine with discarding all the progress made so far on this PR and starting fresh if, in the long run, it makes maintenance easier. Your call, for me is the same if we vendor or if we install https://github.com/kunstmusik/codemirror-lang-csound |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves codemirror from https://github.com/hlolli/codemirror-lang-csound to web-ide.
First approach on addingmulti-assignment, loop, and switch-case syntax. from Csound 7.
Add Markdown language support for .md files and enhance the file tree with an MD badge icon.
Uprading dependencies, migrate to Vite for codemirror, and improve documentation.