Preserve v2 connection Secret reference across pipeline steps#299
Open
fabioaraujopt wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
Preserve v2 connection Secret reference across pipeline steps#299fabioaraujopt wants to merge 1 commit intocrossplane-contrib:mainfrom
fabioaraujopt wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
Reuse the previously desired connection Secret reference as the base when composing v2 XR connection details in subsequent patch-and-transform steps, preventing accidental namespace clobbering while keeping explicit input and patch overrides intact. Signed-off-by: fabioaraujopt <fabioaraujoorg@gmail.com>
fabioaraujopt
requested review from
negz,
phisco,
sergenyalcin,
turkenf and
ulucinar
as code owners
phisco
reviewed
Mar 13, 2026
Comment on lines
+276
to
+281
| if dcd, ok := desired[composedResourceName]; ok && dcd != nil && dcd.Resource != nil { | ||
| existingConnectionSecretRef = &xpv1.SecretReference{ | ||
| Name: dcd.Resource.GetName(), | ||
| Namespace: dcd.Resource.GetNamespace(), | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
could we get an empty namespace by mistake by a previous step? should we guard here for name != "" && namespace != ""?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Secretreference as the base when composing connection details inRunFunctionXR spec.writeConnectionSecretToReffirst) and preserve current behavior when no prior secret existsWhy
In multi-step patch-and-transform pipelines, later steps that omit
writeConnectionSecretToRefcan unintentionally clobber a previously established non-empty namespace, especially for cluster-scoped XRs.Closes #298.
Test plan
go test ./...go mod tidy && git diff --exit-code go.mod go.sumNotes
Signed-off-by: fabioaraujopt <fabioaraujoorg@gmail.com>).