docs: improve WorkermanCompilerPass::referenceMap() PHPDoc#171
Merged
s2x merged 1 commit intocrazy-goat:masterfrom Apr 16, 2026
Merged
Conversation
Describe what the method does, tighten the @param type to the shape returned by findTaggedServiceIds(), and annotate the returned map as service id => Reference rather than a plain list. Closes crazy-goat#146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146.
Replaces the minimal
@param string[] $taggedServices/@return Reference[]PHPDoc onWorkermanCompilerPass::referenceMap()with a description that names the method's purpose and tightens the types:@param array<string, array<string, mixed>> $taggedServicesmatches the shape Symfony'sContainerBuilder::findTaggedServiceIds()returns (the actual callers pass its output in directly, seeWorkermanCompilerPass::process()).@return array<string, Reference>reflects that the map is keyed by service id, not a positional list.No behaviour change.