Conversation
eaa269a to
16bcb29
Compare
…of exit - Add CACHE_WARMUP_TIMEOUT constant (30 seconds) for cache warmup - Use posix_kill(getmypid(), SIGKILL) for success, SIGTERM for error to avoid deadlock with extensions that register shutdown handlers (e.g., grpc) - Handle SIGKILL (9) as success, SIGTERM (15) as error - Throw RuntimeException with clear message on timeout or error - Add tests for SIGKILL success, SIGTERM error, and timeout behavior Fixes #140
16bcb29 to
abe4829
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #140 - Runner hangs indefinitely when cache is empty.
Problem
When the cache was empty,
Runner::run()would fork a child process to warm up the cache. However:exit()in the child caused deadlock with extensions like grpc that register shutdown handlersSolution
posix_kill(getmypid(), SIGKILL)instead ofexit()to avoid deadlockTesting